[PATCH] D26568: [ADT] Delete Twine constructors which accept StringRef rvalues (NFC)

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 13 20:00:26 PST 2016


vsk added a subscriber: jordan_rose.
vsk added a comment.

Hm, this doesn't seem workable. Deleting these constructors would make it harder to pass strings into functions.

Maybe it would be better to try something like r286139, and just delete `Twine &operator=(T &&)` when T is a std::string or a StringRef. @jordan_rose wdyt?


https://reviews.llvm.org/D26568





More information about the llvm-commits mailing list