[PATCH] D26305: [Power9] vector load/store with length - llvm portion

[Nemanja Ivanovic via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Other than the few minor nits about indentation, this LGTM.



================
Comment at: include/llvm/IR/IntrinsicsPowerPC.td:724
       Intrinsic<[llvm_v2f64_ty], [llvm_ptr_ty], [IntrReadMem, IntrArgMemOnly]>;
+def int_ppc_vsx_lxvl :
+      Intrinsic<[llvm_v4i32_ty], [llvm_ptr_ty, llvm_i64_ty], [IntrReadMem,
----------------
Please fix the indentation as follows:

```
def int_ppc_vsx_lxvl :
      Intrinsic<[llvm_v4i32_ty], [llvm_ptr_ty, llvm_i64_ty],
                [IntrReadMem, IntrArgMemOnly]>;
```
Same comment for the definitions below. The third line has the entire contents of the list enclosed in [] and it lines up inside the angle bracket since it is an argument to the `Intrinsic`.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2299
+  def LXVL : XX1Form<31, 269, (outs vsrc:$XT), (ins memr:$src, g8rc:$rB),
+                   "lxvl $XT, $src, $rB", IIC_LdStLoad,
+                   [(set v4i32:$XT, (int_ppc_vsx_lxvl addr:$src, i64:$rB))]>,
----------------
Same as above, the double quote character lines up under the 3 on the line above.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2301
+                   [(set v4i32:$XT, (int_ppc_vsx_lxvl addr:$src, i64:$rB))]>,
+                    UseVSXReg;
+  def LXVLL : XX1Form<31,301, (outs vsrc:$XT), (ins memr:$src, g8rc:$rB),
----------------
This should line up with the `XX1Form` above since it is another class that this definition inherits from.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2349
   // Store Vector (Left-justified) with Length
-  def STXVL    : X_XS6_RA5_RB5<31,  397, "stxvl"   , vsrc, []>;
-  def STXVLL   : X_XS6_RA5_RB5<31,  429, "stxvll"  , vsrc, []>;
+  def STXVL : XX1Form<31, 397, (outs), (ins vsrc:$XT, memr:$dst, g8rc:$rB),
+                   "stxvl $XT, $dst, $rB", IIC_LdStLoad,
----------------
Same indentation comment as above.


https://reviews.llvm.org/D26305