[PATCH] D26562: Bitcode: Change module reader functions to return an llvm::Expected.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/unittests/Bitcode/BitReaderTest.cpp:61
+  if (!ModuleOrErr)
+    report_fatal_error("Could not parse bitcode module");
   return std::move(ModuleOrErr.get());
----------------
mehdi_amini wrote:
> Any error was just ignored before? What was the behavior on error?
It looks like we would just fail the assertion in `ErrorOr::getStorage()`.


https://reviews.llvm.org/D26562