[PATCH] D26467: [ThinLTO] Only promote exported locals as marked in index

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:553
+  auto GUIDPreservedSymbols =
+      computeGUIDPreservedSymbols(PreservedSymbols, TMBuilder.TheTriple);
+
----------------
Not clear why you init TMBuilder, while you only seem to use the Triple?


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:561
+            ExportList->second.count(GUID)) ||
+           GUIDPreservedSymbols.count(GUID);
+  };
----------------
Is it clang-formatted?


================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:80
+    // it must be promoted, so unconditionally promote all values in the
+    // importing module.
+    return true;
----------------
why can't we just promote what is needed?


https://reviews.llvm.org/D26467