[PATCH] D26579: [cmake] Allow CMAKE_BUILD_TYPE=Gentoo

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 12 12:26:33 PST 2016


mgorny added a comment.

In https://reviews.llvm.org/D26579#593694, @beanz wrote:

> This seems to me like a good use for a CMake cache file. Abusing the build type like this seems highly undesirable to me.


I can't say I know the full rationale, since it was like that long before me. What I know, this is causing a major pain with the few projects that force CMAKE_BUILD_TYPE to be one of the upstream-predicted values. I'd really like to be able to build LLVM without necessity of custom patching, and I thought that allowing this specific build type (with its clear characteristic) is more likely to be accepted than removing the (unnecessary, after all) check completely.

The fact is, LLVM is also doing some changes to the build process depending on build type (e.g. appending flags). I know that's one of the things that Gentoo build type attempts to prevent.


https://reviews.llvm.org/D26579





More information about the llvm-commits mailing list