[PATCH] D26437: Use -fno-unit-at-a-time and -funit-at-a-time

[Justin Lebar via llvm-commits]

jlebar added a comment.

To elaborate on why the suggestion I gave is the right thing to do: LLVM will inline convergent functions.  After inlining a convergent function, the fact that it is convergent is lost.  Therefore llvm can transform the body of the function, introducing a divergence.  That will clearly be incorrect.

However, if you add a convergent nop intrinsic to the body of any function that is marked with the convergent attribute, this will behave correctly even in the face of inlining.


Repository:
  rL LLVM

https://reviews.llvm.org/D26437