[PATCH] D26567: Improve DWARF parsing speed by improving DWARFAbbreviationDeclaration

[Paul Robinson via llvm-commits]

probinson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp:68
+          ++FixedAttributeSize->NumAddrs;
+        else if (F == DW_FORM_ref_addr)
+          ++FixedAttributeSize->NumRefAddrs;
----------------
Is there some reason you're only considering FORM_ref_addr here?  I'd think you would want to count all of the format-dependent reference forms here (ref_addr, strp, sec_offset, and all the similar new ones in DWARF 5).  I'd especially think FORM_strp would be important as that's used by pretty much every abbreviation that has a DW_AT_name.


https://reviews.llvm.org/D26567