[PATCH] D26572: RegAllocGreedy: Properly initialize this pass, so that -run-pass will work

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 17:02:31 PST 2016


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:433
+INITIALIZE_PASS_DEPENDENCY(LiveIntervals)
+INITIALIZE_PASS_DEPENDENCY(SlotIndexes)
+INITIALIZE_PASS_DEPENDENCY(RegisterCoalescer)
----------------
duplicate


================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:434-442
+INITIALIZE_PASS_DEPENDENCY(RegisterCoalescer)
+INITIALIZE_PASS_DEPENDENCY(MachineScheduler)
+INITIALIZE_PASS_DEPENDENCY(LiveStacks)
+INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree)
+INITIALIZE_PASS_DEPENDENCY(MachineLoopInfo)
+INITIALIZE_PASS_DEPENDENCY(VirtRegMap)
+INITIALIZE_PASS_DEPENDENCY(LiveRegMatrix)
----------------
There are a number of passes in here that I would not expect (I would only expect the stuff from getAnalysisUsage() here). But I see this was just copied from the constructor, which was equally strange.

So I guess we can leave the cleanup of this list for another commit.


https://reviews.llvm.org/D26572





More information about the llvm-commits mailing list