[PATCH] D26570: AMDGPU/SI: Promote i16 = fp_[us]int f32 for VI

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 16:20:12 PST 2016


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test names fixed



================
Comment at: test/CodeGen/AMDGPU/fp_to_sint.ll:251-254
+; FUNC-LABEL: {{^}}fp_to_sint_i16:
+; SI: v_cvt_i32_f32_e32 [[VAL:v[0-9]+]], s{{[0-9]+}}
+; SI: buffer_store_short [[VAL]]
+define void @fp_to_sint_i16(i16 addrspace(1)* %out, float %in) #0 {
----------------
Test name should include f32_to_i16


================
Comment at: test/CodeGen/AMDGPU/fp_to_uint.ll:249
+; GCN: buffer_store_short [[VAL]]
+define void @fp_to_uint_i16(i16 addrspace(1)* %out, float %in) #0 {
+  %uint = fptoui float %in to i16
----------------
should include source type in name


https://reviews.llvm.org/D26570





More information about the llvm-commits mailing list