[llvm] r286625 - [AArch64] Update a FIXME comment to reflect current state. NFC.
Chad Rosier via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 11 11:52:45 PST 2016
Author: mcrosier
Date: Fri Nov 11 13:52:45 2016
New Revision: 286625
URL: http://llvm.org/viewvc/llvm-project?rev=286625&view=rev
Log:
[AArch64] Update a FIXME comment to reflect current state. NFC.
Modified:
llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
Modified: llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp?rev=286625&r1=286624&r2=286625&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp Fri Nov 11 13:52:45 2016
@@ -1706,8 +1706,10 @@ bool AArch64LoadStoreOpt::runOnMachineFu
return Modified;
}
-// FIXME: Do we need/want a pre-alloc pass like ARM has to try to keep
-// loads and stores near one another?
+// FIXME: Do we need/want a pre-alloc pass like ARM has to try to keep loads and
+// stores near one another? Note: The pre-RA instruction scheduler already has
+// hooks to try and schedule pairable loads/stores together to improve pairing
+// opportunities. Thus, pre-RA pairing pass may not be worth the effort.
// FIXME: When pairing store instructions it's very possible for this pass to
// hoist a store with a KILL marker above another use (without a KILL marker).
More information about the llvm-commits
mailing list