[PATCH] D26549: [ELF] Convert StringTableSection to input section

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/OutputSections.cpp:654
+
+  // Recalculate input section offsets if we own any synthetic section
+  for (auto *SS : In<ELFT>::SyntheticSections)
----------------
I want to mention that this needs to eventually go away by finalizing sections in different order.


================
Comment at: ELF/SyntheticSections.h:223
+class StringTableSection final : public SyntheticSection<ELFT> {
+
+public:
----------------
Remove this blank line.


================
Comment at: ELF/Writer.cpp:928-932
+  //  In<ELFT>::ShStrTab->OutSec->assignOffsets();
+  //  In<ELFT>::StrTab->OutSec->assignOffsets();
+  //  if (In<ELFT>::DynStrTab->OutSec)
+  //    In<ELFT>::DynStrTab->OutSec->assignOffsets();
+
----------------
Remove this.


Repository:
  rL LLVM

https://reviews.llvm.org/D26549