[PATCH] D26409: [AArch64] Fix bugs in isel lowering replaceSplatVectorStore.

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM with a minor suggestion.



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:8779
+  // to, i.e. 0 and 1 for v2i64 and 0, 1, 2, 3 for v4i32.
+  std::bitset<4> IndexNotInserted((1 << NumVecElts) - 1);
+  SDValue SplatVal;
----------------
You might consider using a SmallBitVector.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:8783
   // Check that this is a splat.
-  while (--RemainInsertElts) {
-    SDValue NextInsertElt = StVal.getOperand(0);
----------------
Ouch.


https://reviews.llvm.org/D26409