[llvm] r286593 - Fix test/tools/gold/X86/thinlto_funcimport.ll on non-X86 hosts

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 11 06:35:21 PST 2016


Thanks! I've seen a number of fixes like this periodically, but they don't
seem to be the result of bot failures. Should there be a bot running these
tests on a different arch as a cross-compiler to help catch these earlier?

Teresa

On Fri, Nov 11, 2016 at 6:12 AM, John Brawn via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: john.brawn
> Date: Fri Nov 11 08:12:15 2016
> New Revision: 286593
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286593&view=rev
> Log:
> Fix test/tools/gold/X86/thinlto_funcimport.ll on non-X86 hosts
>
> Pass -m elf_x86_64 to gold, as is done in other tests.
>
> Modified:
>     llvm/trunk/test/tools/gold/X86/thinlto_funcimport.ll
>
> Modified: llvm/trunk/test/tools/gold/X86/thinlto_funcimport.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/go
> ld/X86/thinlto_funcimport.ll?rev=286593&r1=286592&r2=286593&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/tools/gold/X86/thinlto_funcimport.ll (original)
> +++ llvm/trunk/test/tools/gold/X86/thinlto_funcimport.ll Fri Nov 11
> 08:12:15 2016
> @@ -2,7 +2,7 @@
>  ; RUN: opt -module-summary %s -o %t1.bc
>  ; RUN: opt -module-summary %p/Inputs/thinlto_funcimport.ll -o %t2.bc
>
> -; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
> +; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold.so \
>  ; RUN:    --plugin-opt=save-temps \
>  ; RUN:    --plugin-opt=thinlto \
>  ; RUN:    -shared %t1.bc %t2.bc -o %t
> @@ -11,7 +11,7 @@
>
>  ; We shouldn't do any importing at -O0
>  ; rm -f %t2.bc.3.import.bc
> -; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
> +; RUN: %gold -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold.so \
>  ; RUN:    --plugin-opt=save-temps \
>  ; RUN:    --plugin-opt=thinlto \
>  ; RUN:    --plugin-opt=O0 \
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
<(408)%20460-2413>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161111/edc9b5ab/attachment.html>


More information about the llvm-commits mailing list