[PATCH] D26498: [ELF] Convert .got section to input section

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/SyntheticSections.h:74
+  uintX_t getVA() const {
+    return this->OutSec ? this->OutSec->Addr + this->OutSecOff : 0;
+  }
----------------
ruiu wrote:
> Isn't it an error to call getVA before setting OutSec? If so, use assert.
getVA() is called from getPPC64TocBase(), which in its turn is called from scanRelocs(). The Out<ELFT>::Got->getVA() used to return 0 on such occasions, but now we do crash, because we don't have OutSec yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D26498