[LNT] r286539 - This requirement is wrong, previous runs do not have to have the same hash

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Thu Nov 10 19:25:26 2016
New Revision: 286539

URL: http://llvm.org/viewvc/llvm-project?rev=286539&view=rev
Log:
This requirement is wrong, previous runs do not have to have the same hash

Previous runs can come from anywhere and there is no reason for them to
have matching hashes.  IF they do match, we should use that as a larger
or search window.  This commit removes the warning which triggered
all the time.

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=286539&r1=286538&r2=286539&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Thu Nov 10 19:25:26 2016
@@ -342,21 +342,14 @@ class RunInfo(object):
                                 for s in prev_samples
                                 if s[field.index] is not None]
 
-            # All hash_values and all prev_hash_values should all be the same.
+            # All current hash_values should all be the same.
             # Warn in the log when the hash wasn't the same for all samples.
             cur_hash_set = set(hash_values)
-            prev_hash_set = set(prev_hash_values)
             if len(cur_hash_set) > 1:
                 logger.warning(("Found different hashes for multiple samples " +
                                 "in the same run {0}: {1}\nTestID:{2}").format(
                                runs, hash_values, test_id))
-            if len(prev_hash_set) > 1:
-                import pprint
-                logger.warning(("Found different hashes for multiple samples " +
-                                "in the same run {0}\n{1}\nTestID:{2}").format(
-                               pprint.pformat(compare_runs),
-                               prev_hash_values,
-                               test_id))
+
             cur_hash = hash_values[0] if len(hash_values) > 0 else None
             prev_hash = prev_hash_values[0] \
                 if len(prev_hash_values) > 0 else None