[llvm] r285990 - Add a missing return to the move assignment operator for

[Lang Hames via llvm-commits]

Thanks for catching this. I've got a big RPC update in the works that
(among other things) removes these constructors.

- Lang.

On Tue, Nov 8, 2016 at 12:29 PM, Chandler Carruth via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> It's never instantiated because we don't have a unittest that exercises
> this form of increment (see my comment in the commit message).
>
> On Tue, Nov 8, 2016 at 12:20 PM David Blaikie via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Surprised we weren't getting a -Wreturn-type warning for this?
>>
>> On Fri, Nov 4, 2016 at 12:26 AM Chandler Carruth via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>> Author: chandlerc
>> Date: Fri Nov  4 02:16:33 2016
>> New Revision: 285990
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=285990&view=rev
>> Log:
>> Add a missing return to the move assignment operator for
>> SequenceNumberManager.
>>
>> Sadly, we don't have any unittests for this class because it is
>> a private class. Since it seems to have a nice isolated and testable
>> interface, it'd be great to extract it to a detail namespace and write
>> unit tests for it as then we could catch issues. I'll probably pester
>> Lang about that or some alternative refactoring.
>>
>> This was noticed by PVS-Studio.
>>
>> Modified:
>>     llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h
>>
>> Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/
>> llvm/ExecutionEngine/Orc/RPCUtils.h?rev=285990&r1=
>> 285989&r2=285990&view=diff
>> ============================================================
>> ==================
>> --- llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h (original)
>> +++ llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCUtils.h Fri Nov  4
>> 02:16:33 2016
>> @@ -700,6 +700,7 @@ private:
>>      SequenceNumberManager &operator=(SequenceNumberManager &&Other) {
>>        NextSequenceNumber = std::move(Other.NextSequenceNumber);
>>        FreeSequenceNumbers = std::move(Other.FreeSequenceNumbers);
>> +      return *this;
>>      }
>>
>>      void reset() {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161110/5f5d508f/attachment.html>