[PATCH] D26495: [simplifycfg][loop-simplify] Preserve loop metadata in 2 transformations.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 15:34:52 PST 2016


hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

Some minor things about the tests, otherwise LGTM



================
Comment at: test/Transforms/LoopSimplify/preserve-llvm-loop-metadata.ll:31
+; CHECK: br label %while.cond, !llvm.loop !0
+
+
----------------
The code removes the metadata from the old backedges; please add some CHECK-NOT lines to verify that.


================
Comment at: test/Transforms/SimplifyCFG/preserve-llvm-loop-metadata.ll:43
+if.end:                                           ; preds = %if.else, %if.then
+  br label %while.cond, !llvm.loop !1
+
----------------
Shouldn't this be: `!llvm.loop !0` here too.


https://reviews.llvm.org/D26495





More information about the llvm-commits mailing list