[PATCH] D26526: Clean up DWARFFormValue by reducing duplicated code and removing DWARFFormValue::getFixedFormSizes()
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 10 15:23:52 PST 2016
dblaikie added a comment.
I'm not sure I understand the motivation for laziness here - the three things are direct accessors, right? (not virtual, don't do any non-trivial work, should basically be inlined away (one of them has a conditional operator))
I would be a bit surprised if the difference in laziness ever showed up in a profile, but perhaps I'm misunderstanding something about the characteristics of this code/usage/etc.
https://reviews.llvm.org/D26526
More information about the llvm-commits
mailing list