[PATCH] D26333: [AVX-512] Add unmasked version of shift by immediate and shift by single element in XMM.

[Craig Topper via llvm-commits]

craig.topper added a comment.

We could certainly teach InstCombine to handle the masking for the existing intrinsics. I was just going for consistency and not spreading understanding of masking IR to another place.

One concern i have about masking in general is that for a lot of legacy instructions we have have unmasked builtins and I've been wrapping them with selects in IR in the frontend. So the middle end optimizers see the selects and can maybe optimize them through constant folding and the like.. But for 512-bit intrinsics we don't have the selects in IR and instead we have instrinsics that don't expose the same ability to the middle end optimizers.


https://reviews.llvm.org/D26333