[PATCH] D22793: IR: Introduce inbounds attribute on getelementptr indices.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 13:55:33 PST 2016


mehdi_amini added a comment.

The implementation looks good to me.



================
Comment at: include/llvm/IR/Constants.h:1079
                                     bool InBounds = false,
+                                    Optional<unsigned> InRangeIndex = None,
                                     Type *OnlyIfReducedTy = nullptr) {
----------------
Update the doxygen.


================
Comment at: lib/Analysis/ConstantFolding.cpp:906
 
+  // Preserve the inbounds index from the innermost GEP if possible. We must
+  // have calculated the same indices up to and including the inbounds index.
----------------
s/inbounds/inrange/


https://reviews.llvm.org/D22793





More information about the llvm-commits mailing list