[PATCH] D26473: [asan/win] Delay load dbghelp.dll to delay ucrtbase.dll initialization
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 10 13:36:29 PST 2016
rnk added a comment.
In https://reviews.llvm.org/D26473#591256, @kubabrecka wrote:
> Ok, now that you've removed the dependency on dbghelp.dll, is the test (and the binary files) still needed? I mean, now, it doesn't matter what dbghelp.dll depends on.
I don't really see how the code change affects the usefulness of the test. You seem strongly opposed to having a few test binaries in the repo, though. Maybe a better test would be to ensure that the dynamic asan runtime depends only on a whitelist of DLLs, such as kernel32 et al.
https://reviews.llvm.org/D26473
More information about the llvm-commits
mailing list