[PATCH] D26514: Get rid of DWARFFormValue::getFixedFormSizes(uint8_t AddrSize, uint16_t Version).

[David Blaikie via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:419-420
+        }
+      } else {
+        llvm_unreachable("Form must be variable length");
+      }
----------------
This is still a branche-to-unreachable, which should probably just be an assert instead:

  assert(indirect && "Form must ...");
  if (Optional<uint8_t> ...) {
    ...
  }


https://reviews.llvm.org/D26514