[PATCH] D26443: [ELF] - Use backward slashes inside response files

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: test/ELF/reproduce-windows2.s:10
+# RUN: echo "*response.txt" > list.txt
+# RUN: cpio -i --to-stdout --pattern-file=list.txt < repro.cpio | FileCheck %s
+# CHECK: {{.*}}/build/foo.o
----------------
grimar wrote:
> ruiu wrote:
> > Don't use --to-stdout as it won't work on non-GNU systems.
> I wonder how to make a test then.
> 
> I think we can not unpack cpio on windows as "can get over the path limit on windows" like mentioned in reproduce-error.s.
> Since this test is about windows specific functionality, what about running it on windows only ?
Being on Windows doesn't mean that the installed cpio command is GNU's, but maybe it's a fairly reasonable assumption.


================
Comment at: test/lit.cfg:210
 
+# Running on Windows
+if platform.system() in ['Windows']:
----------------
rafael wrote:
> llvm use the name system-windows.
> 
> This is basically assuming that the cpio on windows is gnu, which I think is fine. Rui, is that OK?
Yup.


https://reviews.llvm.org/D26443