[PATCH] D26474: Parse resolations only once

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 12:43:03 PST 2016


All I have to do is to just leave "Differential revision" line in a commit
message, then the "git svn commit" automatically updates and closes the
corresponding phab patch for me. I don't know how it works, I probably
didn't set it up, so it's the out of the box behavior for me. I honestly
don't care at  all whether my Phab patches are left open or not, but since
it's easy to close, I didn't find it that annoying. What's the problem with
Phab? Is it fixable? Phab is useful for me to review, so please don't stop
using it.

On Thu, Nov 10, 2016 at 11:45 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 10 November 2016 at 14:44, Eugene Zelenko <eugene.zelenko at gmail.com>
> wrote:
> > Eugene.Zelenko closed this revision.
> > Eugene.Zelenko added a comment.
> >
> > Committed in https://reviews.llvm.org/rL286459. Please read
> http://llvm.org/docs/Phabricator.html#committing-a-change.
>
> As pointed out before, I find phab way to annoying to use in full. If
> the policy is all or nothing I will just stop using it completely.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161110/639afe01/attachment.html>


More information about the llvm-commits mailing list