[PATCH] D26436: Fix for lost FastMathFlags in 4 optimizations.

[David Majnemer via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:1783-1785
+    FastMathFlags FMF;
+    FMF.setUnsafeAlgebra();
+    Builder.setFastMathFlags(FMF);
----------------
This would be more obvious if you did: `Builder.setFastMathFlags(cast<FPMathOperator>(I)->getFastMathFlags())`


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2425
 
-      CmpInst::Predicate P0 = cast<CmpInst>(VL0)->getPredicate();
+      CmpInst *CI = cast<CmpInst>(VL0);
+      CmpInst::Predicate P0 = CI->getPredicate();
----------------
`auto *CI`


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2431-2432
+        cast<FCmpInst>(V)->copyFastMathFlags(CI);
+      } else
         V = Builder.CreateICmp(P0, L, R);
 
----------------
Please consistently brace.


https://reviews.llvm.org/D26436