[PATCH] D26455: Handle non-inlined clang::Type::getAs specializations in extract_symbols.py

[John Brawn via llvm-commits]

john.brawn added inline comments.


================
Comment at: utils/extract_symbols.py:136
+    # definition is public
+    elif symbol == '??$getAs at VAttributedType@clang@@@Type at clang@@QEBAPEBVAttributedType at 1@XZ' \
+         or symbol == '??$getAs at VTemplateSpecializationType@clang@@@Type at clang@@QEBAPEBVTemplateSpecializationType at 1@XZ' \
----------------
Instead of listing each symbol specifically it would be better to use a regex, e.g. re.match('??$getAs.+Type at clang@@') (note: I haven't tested this regex to check that it works).


================
Comment at: utils/extract_symbols.py:210
     # definition is public
+    elif symbol == '_ZNK5clang4Type5getAsINS_14AttributedTypeEEEPKT_v' \
+         or symbol == '_ZNK5clang4Type5getAsINS_26TemplateSpecializationTypeEEEPKT_v' \
----------------
Same here, though here you can just check that the symbol starts with _ZNK5clang4Type5getAs.


https://reviews.llvm.org/D26455