[PATCH] D26502: Split Bitcode/ReaderWriter.h into separate reader and writer headers

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 07:09:17 PST 2016


tejohnson created this revision.
tejohnson added a reviewer: chandlerc.
tejohnson added subscribers: llvm-commits, mehdi_amini, dlj.

Split ReaderWriter.h which contains the APIs into both the BitReader and
BitWriter libraries into BitcodeReader.h and BitcodeWriter.h.

This is to address Chandler's concern about sharing the same API header
between multiple libraries (BitReader and BitWriter). That concern is
why we create a single bitcode library in our downstream build of clang,
which led to r286297 being reverted as it added a dependency that
created a cycle only when there is a single bitcode library (not two as
in upstream).


https://reviews.llvm.org/D26502

Files:
  include/llvm/Bitcode/BitCodes.h
  include/llvm/Bitcode/BitcodeReader.h
  include/llvm/Bitcode/ReaderWriter.h
  lib/Bitcode/Reader/BitReader.cpp
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitWriter.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/Bitcode/Writer/BitcodeWriterPass.cpp
  lib/CodeGen/ParallelCG.cpp
  lib/IR/Core.cpp
  lib/IRReader/IRReader.cpp
  lib/LTO/LTO.cpp
  lib/LTO/LTOBackend.cpp
  lib/LTO/LTOCodeGenerator.cpp
  lib/LTO/LTOModule.cpp
  lib/LTO/ThinLTOCodeGenerator.cpp
  lib/Object/IRObjectFile.cpp
  lib/Object/ModuleSummaryIndexObjectFile.cpp
  tools/bugpoint/OptimizerDriver.cpp
  tools/gold/gold-plugin.cpp
  tools/lli/lli.cpp
  tools/llvm-as/llvm-as.cpp
  tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
  tools/llvm-dis/llvm-dis.cpp
  tools/llvm-link/llvm-link.cpp
  tools/llvm-lto/llvm-lto.cpp
  tools/llvm-split/llvm-split.cpp
  tools/lto/lto.cpp
  tools/verify-uselistorder/verify-uselistorder.cpp
  unittests/Bitcode/BitReaderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26502.77480.patch
Type: text/x-patch
Size: 18548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161110/58203125/attachment.bin>


More information about the llvm-commits mailing list