[lld] r286458 - Reverted r286451 "[ELF] - Allow separate form for -f (alias for -auxiliary)."

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 10 06:48:40 PST 2016


Author: grimar
Date: Thu Nov 10 08:48:39 2016
New Revision: 286458

URL: http://llvm.org/viewvc/llvm-project?rev=286458&view=rev
Log:
Reverted r286451 "[ELF] - Allow separate form for -f (alias for -auxiliary)."

Though the patch was technically correct,
the only FreeBSD port (noticed atm) that tried using it was
www/mod_jk. And it seems just passed gcc option to linker by mistake:

"-Wl,-L-L/usr/local/lib -Wl,-rpath,/usr/local/lib -Wl,-fstack-protector -Wl,-fstack-protector -o mod_jk.la "

Given that it is an easy mistake to make, reverting for now.



Modified:
    lld/trunk/ELF/Options.td

Modified: lld/trunk/ELF/Options.td
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=286458&r1=286457&r2=286458&view=diff
==============================================================================
--- lld/trunk/ELF/Options.td (original)
+++ lld/trunk/ELF/Options.td Thu Nov 10 08:48:39 2016
@@ -223,7 +223,7 @@ def z: JoinedOrSeparate<["-"], "z">, Met
   HelpText<"Linker option extensions">;
 
 // Aliases
-def alias_auxiliary: JoinedOrSeparate<["-"], "f">, Alias<auxiliary>;
+def alias_auxiliary: Separate<["-"], "f">, Alias<auxiliary>;
 def alias_Bdynamic_call_shared: F<"call_shared">, Alias<Bdynamic>;
 def alias_Bdynamic_dy: F<"dy">, Alias<Bdynamic>;
 def alias_Bstatic_dn: F<"dn">, Alias<Bstatic>;




More information about the llvm-commits mailing list