[PATCH] D26449: DAGCombiner: fix combine of trunc and select
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 10 06:33:38 PST 2016
spatel added a comment.
Thanks for tracking this down!
1. Please use the regression test from:
https://llvm.org/bugs/show_bug.cgi?id=29002#c1
I think that's the minimal case. If you want to include the original test in this patch, I suppose that's ok, but I don't think it actually adds value. Zvi's example in:
https://llvm.org/bugs/show_bug.cgi?id=29002#c2
probably is interesting as it shows a different output?
2. Please use utils/update_llc_test_checks.py to auto-generate complete checks (and then remove any lines that you think are irrelevant).
Repository:
rL LLVM
https://reviews.llvm.org/D26449
More information about the llvm-commits
mailing list