[PATCH] D26496: [ELF] - Allow calls to a protected function in a shared library from non-PIC code.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.


================
Comment at: ELF/Relocations.cpp:449
+
+  // GNU linkers allows non PIC program calls to a protected
+  // function in a shared library. We do the same.
----------------
I think this is wrong.

It is possible that we should accept the test for other reasons, but at this point in the code we are trying to preempt a symbol, and that is not possible with protected visibility.

It is possible the address is not significant, but we don't know that. There is no flag in ELF to inform us.



https://reviews.llvm.org/D26496