[PATCH] D26488: [GVN] Basic optimization remark support

[Davide Italiano via llvm-commits]

davide added a comment.

You're mentioning that more interesting cases will be added in later patches, can you please elaborate what else do you have in mind (other than load elim?)



================
Comment at: lib/IR/DiagnosticInfo.cpp:183-188
+DiagnosticInfoOptimizationBase::Argument::Argument(StringRef Key, Type *T)
+    : Key(Key) {
+  raw_string_ostream OS(Val);
+  OS << *T;
+}
+
----------------
I assume you're using this but it's not strictly tied to the patch, i.e. maybe can be committed separately? (up to you)


================
Comment at: lib/Transforms/Scalar/GVN.cpp:1807-1808
     ++NumGVNLoad;
+    DEBUG(
+        dbgs() << "GVN: load eliminated: " << *L << "\n");
+    ORE->emit(OptimizationRemark(DEBUG_TYPE, "LoadElim", L)
----------------
I see here you're adding this `DEBUG` statement before emitting the remark but you don't in the other two cases. Is this intended?


https://reviews.llvm.org/D26488