[PATCH] D26460: Tread TSan LLVM flags to driver: account for external flag values in TSan.

[Aleksey Shlyapnikov via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/ThreadSanitizer.cpp:85
 struct ThreadSanitizer : public FunctionPass {
-  ThreadSanitizer() : FunctionPass(ID) {}
+  ThreadSanitizer(bool DetectDataRaces = true,
+                  bool StackTraces = true,
----------------
dvyukov wrote:
> Do we need default parameter values here? I would expect that not.
Yes, we do.  FunctionPass is expected to have a zero arg ctor (see PassSupport.h, callDefaultCtor).


https://reviews.llvm.org/D26460