[PATCH] D26155: Enable Loop Sink pass for functions that has profile.

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp:650
 
+  MPM.add(createLoopSinkPass());
+  // Get rid of LCSSA nodes.
----------------
davidxl wrote:
> mzolotukhin wrote:
> > Can't we schedule this right after LICM?
> > I think we're placing LoopSinking in a separate instance of loop pass manager - is that what we want?
> LICM also serves as an IR canonicalization pass that enables other optimization, so loopSinking needs to be a very late IR pass to avoid undoing LICM result too early. Otherwise the logic of loopSinking can be baked into LICM as proposed originally.
Can we have a comment here, the PassManagerBuilder is already hard to follow, it'd be great to bake in why passes are there, and why they are where they are. 


Repository:
  rL LLVM

https://reviews.llvm.org/D26155