[PATCH] D26460: Tread TSan LLVM flags to driver: account for external flag values in TSan.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 16:38:25 PST 2016


eugenis added a comment.

Attribute is definitely the right long term solution, but it would be more efficient to move all sanitizer options to attributes in bulk. It also adds overhead (possibly tiny) compared to the pass argument approach, so it only makes sense to do if we plan to move instrumentation passes to the link stage right away. I don't think we want to work on that right now.

So the question is, do we want this temporary implementation, or are we fine with -mllvm flags? Seeing as the code is already written, I'd prefer to land this change now.


https://reviews.llvm.org/D26460





More information about the llvm-commits mailing list