[PATCH] D26379: [LLD] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 15:37:00 PST 2016


So, as pointed out in a private discussion, currently

http://llvm.org/docs/CodingStandards.html#include-as-little-as-possible

says  "you can include them either directly or indirectly through
another header file.".

I will not have an opinion on that statement, but I think we should
change it before we start using include what you use in lld.

Cheers,
Rafael



On 7 November 2016 at 19:54, Eugene Zelenko via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Eugene.Zelenko created this revision.
> Eugene.Zelenko added a reviewer: ruiu.
> Eugene.Zelenko added a subscriber: llvm-commits.
> Eugene.Zelenko set the repository for this revision to rL LLVM.
>
> I checked this patch on my own build on RHEL 6. Regressions were OK.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26379
>
> Files:
>   COFF/InputFiles.h
>   ELF/Target.cpp
>   lib/ReaderWriter/MachO/ArchHandler.cpp
>   lib/ReaderWriter/MachO/MachOLinkingContext.cpp
>   lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list