[PATCH] D26353: Add isHot{Cold}BB API to ProfileSummaryInfo

[David Li via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:134
+  // to ensure all hot BB will not be missed. Optimizations that clones code
+  // (e.g. inlining) need to update branch_probability to ensure
+  // extractProfTotalWeight is up-to-date. Otherwise, cold BB may be mis-labeled
----------------
I think it is better to document the behavior this way:

The query currently has false positives as branch instruction cloning does not update/scale branch weights. Unlike false negatives, this won't cause performance problem.


https://reviews.llvm.org/D26353