[PATCH] D26443: [ELF] - Use backward slashes inside response files

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: lib/Core/Reproduce.cpp:79
 // assuming that the current directory is "/home/john/bar".
 std::string lld::relativeToRoot(StringRef Path) {
   SmallString<128> Abs = Path;
----------------
Please add a comment when you do something not obvious.

  // Returned string is a slash-separated path even on Windows to avoid
  // a mess with backslash-as-escape and backslash-as-path-separator.


================
Comment at: test/ELF/reproduce-windows2.s:10
+# RUN: echo "*response.txt" > list.txt
+# RUN: cpio -i --to-stdout --pattern-file=list.txt < repro.cpio | FileCheck %s
+# CHECK: {{.*}}/build/foo.o
----------------
Don't use --to-stdout as it won't work on non-GNU systems.


https://reviews.llvm.org/D26443