[PATCH] D22696: [CodeGenPrep] Skip merging empty case blocks

Wed Nov 9 11:41:42 PST 2016

manmanren added inline comments.

================
Comment at: test/CodeGen/X86/ragreedy-hoist-spill.ll:183
+  ; CHECK: movq %r{{.*}}, {{[0-9]+}}(%rsp)
+  ; CHECK: land.rhs485
   %cmp476 = icmp eq i8 undef, 0
----------------
The whole purpose of this testing case is to make sure that a spill is not hoisted to a hotter outer loop.

As long as that is still true with your change, it is fine.

https://reviews.llvm.org/D22696