[PATCH] D26413: [XRay] Support AArch64 in compiler-rt

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 10:44:53 PST 2016


rSerge added a comment.

In https://reviews.llvm.org/D26413#590316, @dberris wrote:

> Thanks for doing this @rSerge! Do you have a plan for supporting tail-exit sleds either now or at a later time?
>
> I ask because the x86_64 code has already started differentiating tail-exit sleds by having its own trampoline. Maybe this distinction isn't necessary in ARM, but was wondering whether there was something that needed to be done here.


I saw your recent commit with tail-exit sleds https://reviews.llvm.org/D26020 , and I plan to implement this too, but not in the current series of commits. Because ARM32 doesn't have this either, so I would rather commit ARM32 and AArch64 tail-exit sled handling together, than diverging in the current series between ARM32 and AArch64. ARM32 still doesn't support Thumb CPU mode, so some prioritizing is needed which one to do first and definitely not all at once.


https://reviews.llvm.org/D26413





More information about the llvm-commits mailing list