[PATCH] D26462: Tread TSan LLVM flags to driver: unit tests.

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 9 10:01:53 PST 2016


kubabrecka added inline comments.


================
Comment at: test/tsan/atomic_free.cc:1-2
-// RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t >%t.out 2>&1
+// RUN: FileCheck %s <%t.out
+
----------------
Why not just use a pipe instead of writing to `%t.out`?  If you're doing this only to maintain 80-column width, then you can split a line using a backslash:

    // RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t 2>&1 \
    // RUN:   | FileCheck %s

Anyway, I think RUN commands are allowed to be longer that 80 columns (but others probably disagree), there's a lot of tests already doing that.


https://reviews.llvm.org/D26462





More information about the llvm-commits mailing list