[PATCH] D26177: [tsan] Add support for C++ exceptions into TSan (call __tsan_func_exit during unwinding)

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 17:14:17 PST 2016


kubabrecka added a comment.

In https://reviews.llvm.org/D26177#590185, @dvyukov wrote:

> 1. Please add tsan pass flag that turns exception interception off. We may need to disable it during deployment if it causes instability, compilation errors or too large binary increase.


Will do.  What's "too large" for you?  This does cause increases, which are larger in -O0 builds.

> 2. Are we sure that longjmp won't cause double call to __tsan_func_exit? At least MSVC longjmp will unwind stack and call destructors, which will most likely lead to double exit calls. Linux docs are vague in this regard. Not sure about mac.

I'll try to check.  Besides longjmp, do you have some particular scenario that's worth adding a testcase for?


https://reviews.llvm.org/D26177





More information about the llvm-commits mailing list