[PATCH] D26402: [ThinLTO] Make inline assembly handling more efficient in summary

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 14:55:37 PST 2016


mehdi_amini added a comment.

I'm not concerned about saving a bit of spending a little more compile time, but more about not maintaining redundant information, which can make things harder to understand in general (and invariant harder to maintain/enforce).

We shouldn't have to spend compile time in the promotion phase, and I don't expect this flag to be used here anyway, because we promote only what is exported and such "NoRename" symbol shouldn't be exported in the first place.


https://reviews.llvm.org/D26402





More information about the llvm-commits mailing list