[PATCH] D26425: Split Header into individual fields

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/OutputSections.cpp:41
+  this->Flags = Flags;
+  Addralign = 1;
 }
----------------
Why only Addralign doesn't have `this->`?


================
Comment at: ELF/OutputSections.h:113
   StringRef Name;
-  Elf_Shdr Header;
+  uintX_t Size = 0;
+  uintX_t Entsize = 0;
----------------
Add a comment saying that these fields correspond to Elf_Shdr members.


================
Comment at: ELF/Writer.cpp:426-427
   typedef typename ELFT::uint uintX_t;
-  uintX_t AFlags = A->getFlags();
-  uintX_t BFlags = B->getFlags();
+  uintX_t AFlags = A->Flags;
+  uintX_t BFlags = B->Flags;
 
----------------
It doesn't make much sense to write `AFlags` instead of `A->Flags`. Can you remove these variables?


https://reviews.llvm.org/D26425