[lld] r286100 - [ELF] Make InputSection<ELFT>::writeTo virtual

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 14:48:10 PST 2016


On 8 November 2016 at 16:28, Rui Ueyama <ruiu at google.com> wrote:
> I don't know how much we could get from virtualizing writeTo (so I'm okay to
> revert this for now), but if the cost of having it is sub-1% and if it will
> improve readability quite a lot, I'd vote for readability over performance.
> So virtualizing writeTo is still an option.


Any thought on the idea of having a SyntheticSection class? That can
be the first one with virtual functions.

Cheers,
Rafael


More information about the llvm-commits mailing list