[PATCH] D24338: [InlineCost] Remove CallPenalty and change MinSizeThreshold to 5
Easwaran Raman via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 8 14:37:17 PST 2016
eraman added a comment.
In https://reviews.llvm.org/D24338#589426, @eraman wrote:
> In https://reviews.llvm.org/D24338#588190, @davidxl wrote:
>
> > This one looks good.
> >
> > Easwaran, can you help measure the performance impact of this change with internal benchmarks?
>
>
> This is hurting one of our internal benchmarks by > 5%. I'm looking into the root cause now.
It turns out this is due to a bug in a local inliner patch we have that got exposed by this (and that prevented one crucial function from being inlined). This patch itself LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D24338
More information about the llvm-commits
mailing list