[PATCH] D21739: [TLI] Add functions determining if int parameters/returns should be zeroext/signext.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 8 13:22:26 PST 2016


hfinkel added a comment.

In https://reviews.llvm.org/D21739#589647, @davidxl wrote:

> This seems fine. Hal, do you have other concerns?


Generally, I think this is the right approach. Do we only have a use case for i32, or would it apply to i16, i8, i1 too? If we only have a use case for i32 right now, I'm fine with leaving generalization to when we have use cases for other types.

Is the diff now missing something? I don't see anything here that would cause a functional change, but there's a test case which implies otherwise.


Repository:
  rL LLVM

https://reviews.llvm.org/D21739





More information about the llvm-commits mailing list