[PATCH] D26146: [ThinLTO] Prevent exporting of locals used/defined in module level asm

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D26146#589843, @mehdi_amini wrote:

> (See also one nit inline)


Got it. Thanks!



================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:286
+          // Create the appropriate summary type.
+          if (dyn_cast<Function>(GV)) {
+            std::unique_ptr<FunctionSummary> Summary =
----------------
mehdi_amini wrote:
> Use `isa<>` instead of `dyn_cast<>` if you don't use the result.
Fixed.


https://reviews.llvm.org/D26146