[PATCH] D26146: [ThinLTO] Prevent exporting of locals used/defined in module level asm

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

LGTM, thanks.
(Ideally we should have a test that verifies that the encoding in the bitcode itself is as expected with llvm-bcanalyzer, but such tests are more difficult to maintain).



================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:286
+          // Create the appropriate summary type.
+          if (dyn_cast<Function>(GV)) {
+            std::unique_ptr<FunctionSummary> Summary =
----------------
Use `isa<>` instead of `dyn_cast<>` if you don't use the result.


https://reviews.llvm.org/D26146