[PATCH] D16077: DIBuilder support DI Macro creation

Tue Nov 8 12:15:31 PST 2016

aaboud added a comment.

In https://reviews.llvm.org/D16077#498128, @aprantl wrote:

> Yes, I think putting it on DIMacroFile might be a better interface, but I'm not sure.
>  But then there is also another issue: I'm not sure whether it is legal to modify a uniquable (non-distinct) DINode because it will break uniquing. So I think DIMacroFiles must be created distinct to avoid this problem. Would this cause an issue during LTO with duplication or are they expected to be mostly unique across compile units anyway?

In https://reviews.llvm.org/D16077#588644, @aprantl wrote:

> What's the status of this?

Sorry, for the delay, I was in an extended vacation.
Following F2F discussion with Richard Smith in the LLVM conference I have now some ideas on how to implement the Macro support in Clang.
So, expect new patches in the comming few weeks.

Again, sorry for the delay.

Regards,
Amjad

https://reviews.llvm.org/D16077