[PATCH] D26379: [LLD] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes

[Eugene Zelenko via llvm-commits]

Eugene.Zelenko added inline comments.


================
Comment at: ELF/Target.cpp:35
+#include "llvm/Object/ELFTypes.h"
+#include "llvm/Support/Casting.h"
 #include "llvm/Support/ELF.h"
----------------
rafael wrote:
> I am not sure how to properly manage this include list if we are going the Include What You Use way. How do we make sure we are not including unnecessary headers?
Sure, Include What You Use may have false positives and it is not supporting libc++ well. But I manually checked that all added headers are used explicitly.

See D26320 as example where manual headers maintenance was less then adequate.

Please try  Include What You Use. It prints used declarations in comments after each include directive.


Repository:
  rL LLVM

https://reviews.llvm.org/D26379